Add GitHub actions to build and package #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristotelos
force-pushed
the
test-github-actions
branch
3 times, most recently
from
ecb39e5 to
bbd7c5e
Compare
aristotelos
changed the title
aristotelos
force-pushed
the
test-github-actions
branch
2 times, most recently
from
9e8e7e0 to
a94b582
Compare
Based on https://github.com/actions/starter-workflows/blob/main/ci/dotnet.yml. This requires the WpfApplication to be converted to a .NET 6 project and added to the UITests project dependencies so that it is built before it is used in the tests.
Remove web.config because we don't need IIS support, do not publish appsettings.Development.json.
aristotelos
force-pushed
the
test-github-actions
branch
from
ddcbab3 to
1712283
Compare
|
@Roemer Do you plan to review this PR? If you do, please let me know, otherwise I will just merge it. |
|
Very cool, thanks for your work! As Action-Artefacts will get removed after some time, should we just create github releases with the binary? |
|
Yes, I would like to use GitHub releases. I think it is simple to add a https://github.com/marketplace/actions/gh-release action to create a release on a tag. I think I'll create a PR to enable that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/actions/starter-workflows/blob/main/ci/dotnet.yml.
This requires the WpfApplication to be converted to a .NET 6 project and added to the UITests project dependencies so that it is built before it is used in the tests.